poorbarcode commented on code in PR #21212:
URL: https://github.com/apache/pulsar/pull/21212#discussion_r1394106031
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java:
##########
@@ -281,9 +289,37 @@ public CompletableFuture<Optional<TopicPolicies>>
getTopicPoliciesAsync(@NotNull
@Override
public TopicPolicies getTopicPoliciesIfExists(TopicName topicName) {
+ return mergeTopicPolicies(getLocalTopicPolicies(topicName),
getGlobalTopicPolicies(topicName));
+ }
+
+ private TopicPolicies mergeTopicPolicies(TopicPolicies localTopicPolicies,
TopicPolicies globalTopicPolicies) {
+
+ if (localTopicPolicies == null && globalTopicPolicies == null) {
+ return null;
+ }
+
+ if (localTopicPolicies == null && globalTopicPolicies != null) {
+ return globalTopicPolicies;
+ }
+
+ if (globalTopicPolicies == null && localTopicPolicies != null) {
+ return localTopicPolicies;
+ }
+
+ TopicPolicies topicPolicies = new TopicPolicies();
+ BeanUtil.copyProperties(globalTopicPolicies, topicPolicies, true);
Review Comment:
Oh, I think the original implementation is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
