AnonHxy commented on code in PR #21595:
URL: https://github.com/apache/pulsar/pull/21595#discussion_r1399947803
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTrackerFactory.java:
##########
@@ -35,6 +37,7 @@
import
org.apache.pulsar.broker.service.persistent.PersistentDispatcherMultipleConsumers;
import org.apache.pulsar.common.util.FutureUtil;
+@Slf4j
Review Comment:
Not necessary change.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTrackerFactory.java:
##########
@@ -85,6 +88,9 @@ public DelayedDeliveryTracker
newTracker(PersistentDispatcherMultipleConsumers d
*/
public CompletableFuture<Void> cleanResidualSnapshots(ManagedCursor
cursor) {
Map<String, String> cursorProperties = cursor.getCursorProperties();
+ if (MapUtils.isEmpty(cursorProperties)) {
Review Comment:
I wonder which place introduce the `null` cursorProperties. And if so,
should all the place check `cursorProperties` is empty or not:)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
