Technoboy- commented on code in PR #21630:
URL: https://github.com/apache/pulsar/pull/21630#discussion_r1413924217


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v3/Transactions.java:
##########
@@ -439,4 +439,33 @@ public void getPositionStatsInPendingAck(@Suspended final 
AsyncResponse asyncRes
         }
     }
 
+    @POST
+    @Path("/abortTransaction/{mostSigBits}/{leastSigBits}")
+    @ApiOperation(value = "Abort transaction")
+    @ApiResponses(value = {
+            @ApiResponse(code = 404, message = "Tenant or cluster or namespace 
or topic "
+                    + "or coordinator or transaction doesn't exist"),
+            @ApiResponse(code = 503, message = "This Broker is not configured "
+                    + "with transactionCoordinatorEnabled=true."),
+            @ApiResponse(code = 307, message = "Topic is not owned by this 
broker!"),
+            @ApiResponse(code = 400, message = "Topic is not a persistent 
topic!"),
+            @ApiResponse(code = 409, message = "Concurrent modification"),
+            @ApiResponse(code = 401, message = "This operation requires 
super-user access")})
+    public void abortTransaction(@Suspended final AsyncResponse asyncResponse,
+                                 @QueryParam("authoritative")
+                                 @DefaultValue("false") boolean authoritative,
+                                 @PathParam("mostSigBits") String mostSigBits,
+                                 @PathParam("leastSigBits") String 
leastSigBits) {

Review Comment:
   Why not long `mostSigBits` and `leastSigBits` ?



##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java:
##########
@@ -250,6 +250,19 @@ void run() throws Exception {
         }
     }
 
+    @Parameters(commandDescription = "Abort transaction")
+    private class AbortTransaction extends CliCommand {
+        @Parameter(names = {"-m", "--most-sig-bits"}, description = "The most 
sig bits", required = true)
+        private int mostSigBits;

Review Comment:
   long 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to