heesung-sn commented on code in PR #21668:
URL: https://github.com/apache/pulsar/pull/21668#discussion_r1414494799
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -200,33 +197,25 @@ enum MetadataState {
Unstable
}
- public static ServiceUnitStateChannelImpl newInstance(PulsarService
pulsar) {
- return new ServiceUnitStateChannelImpl(pulsar);
- }
-
- public ServiceUnitStateChannelImpl(PulsarService pulsar) {
- this(pulsar, MAX_IN_FLIGHT_STATE_WAITING_TIME_IN_MILLIS,
OWNERSHIP_MONITOR_DELAY_TIME_IN_SECS);
- }
-
@VisibleForTesting
- public ServiceUnitStateChannelImpl(PulsarService pulsar,
- long inFlightStateWaitingTimeInMillis,
- long ownershipMonitorDelayTimeInSecs) {
+ public ServiceUnitStateChannelImpl(PulsarService pulsar) {
this.pulsar = pulsar;
this.config = pulsar.getConfig();
this.lookupServiceAddress = pulsar.getLookupServiceAddress();
this.schema = Schema.JSON(ServiceUnitStateData.class);
this.getOwnerRequests = new ConcurrentHashMap<>();
this.cleanupJobs = new ConcurrentHashMap<>();
this.stateChangeListeners = new StateChangeListeners();
- this.semiTerminalStateWaitingTimeInMillis =
config.getLoadBalancerServiceUnitStateTombstoneDelayTimeInSeconds()
+ this.stateTombstoneDelayTimeInSeconds =
config.getLoadBalancerServiceUnitStateTombstoneDelayTimeInSeconds()
* 1000;
Review Comment:
oh thanks for this catch. The name should `stateTombstoneDelayTimeInMillis`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
