Technoboy- commented on code in PR #21667:
URL: https://github.com/apache/pulsar/pull/21667#discussion_r1415502058
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -1621,6 +1621,14 @@ The delayed message index time step(in seconds) in per
bucket snapshot segment,
)
private boolean httpRequestsFailOnUnknownPropertiesEnabled = false;
+ @FieldContext(
+ category = CATEGORY_HTTP,
+ doc = "Enable support for compressing HTTP responses. However,
enabling this feature does not guarantee"
+ + " that the response will be compressed. The decision to compress
the response depends on whether the"
+ + " client's request header contains the `Accept-Encoding: gzip`
flag."
+ )
+ private boolean httpResponseCompressionEnabled = false;
Review Comment:
Seems enable it as default is a good choice ？
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -1621,6 +1621,14 @@ The delayed message index time step(in seconds) in per
bucket snapshot segment,
)
private boolean httpRequestsFailOnUnknownPropertiesEnabled = false;
+ @FieldContext(
+ category = CATEGORY_HTTP,
+ doc = "Enable support for compressing HTTP responses. However,
enabling this feature does not guarantee"
+ + " that the response will be compressed. The decision to compress
the response depends on whether the"
+ + " client's request header contains the `Accept-Encoding: gzip`
flag."
+ )
+ private boolean httpResponseCompressionEnabled = false;
Review Comment:
Seems enable it as default is a good choice ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
