(pulsar) branch master updated: [fix][test] add unit test to testing the lookupRequestSemaphore would leaked when lookuping topic is not exist. (#21670)

[technoboy]

This is an automated email from the ASF dual-hosted git repository.

technoboy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 91c9e0a48ef [fix][test] add unit test to testing the 
lookupRequestSemaphore would leaked when lookuping topic is not exist. (#21670)
91c9e0a48ef is described below

commit 91c9e0a48ef9a0b86727485a1b16fbc95aa58eb3
Author: PAN <46820719+pandale...@users.noreply.github.com>
AuthorDate: Tue Dec 5 21:26:12 2023 +0800

    [fix][test] add unit test to testing the lookupRequestSemaphore would 
leaked when lookuping topic is not exist. (#21670)
---
 .../broker/lookup/http/HttpTopicLookupv2Test.java  | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git 
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/lookup/http/HttpTopicLookupv2Test.java
 
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/lookup/http/HttpTopicLookupv2Test.java
index 6a6065bc289..7004eae29b5 100644
--- 
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/lookup/http/HttpTopicLookupv2Test.java
+++ 
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/lookup/http/HttpTopicLookupv2Test.java
@@ -278,4 +278,36 @@ public class HttpTopicLookupv2Test {
         assertEquals(data2.getRedirectLookupAddress(), url);
     }
 
+    @Test
+    public void topicNotFound() throws Exception {
+        MockTopicLookup destLookup = spy(MockTopicLookup.class);
+        doReturn(false).when(destLookup).isRequestHttps();
+        BrokerService brokerService = pulsar.getBrokerService();
+        doReturn(new 
Semaphore(1000,true)).when(brokerService).getLookupRequestSemaphore();
+        destLookup.setPulsar(pulsar);
+        doReturn("null").when(destLookup).clientAppId();
+        Field uriField = PulsarWebResource.class.getDeclaredField("uri");
+        uriField.setAccessible(true);
+        UriInfo uriInfo = mock(UriInfo.class);
+        uriField.set(destLookup, uriInfo);
+        URI uri = 
URI.create("http://localhost:8080/lookup/v2/destination/topic/myprop/usc/ns2/topic1";);
+        doReturn(uri).when(uriInfo).getRequestUri();
+        config.setAuthorizationEnabled(true);
+        NamespaceService namespaceService = pulsar.getNamespaceService();
+        CompletableFuture<Boolean> future = new CompletableFuture<>();
+        future.complete(false);
+        
doReturn(future).when(namespaceService).checkTopicExists(any(TopicName.class));
+
+        // Get the current semaphore first
+        Integer state1 = 
pulsar.getBrokerService().getLookupRequestSemaphore().availablePermits();
+        AsyncResponse asyncResponse1 = mock(AsyncResponse.class);
+        // We used a nonexistent topic to test
+        destLookup.lookupTopicAsync(asyncResponse1, 
TopicDomain.persistent.value(), "myprop", "usc", "ns2", "topic2", false, null, 
null);
+        // Gets semaphore status
+        Integer state2 = 
pulsar.getBrokerService().getLookupRequestSemaphore().availablePermits();
+        // If it is successfully released, it should be equal
+        assertEquals(state1, state2);
+
+    }
+
 }