nodece opened a new pull request, #21673:
URL: https://github.com/apache/pulsar/pull/21673

   ### Motivation
   
   `GeoPersistentReplicator.msgOut` metric records the message output data from 
the local cluster to the remote cluster. Right now, this metric has been 
updated before getting the shema. If it fails,  we don't send the message to 
the remote cluster, so I don't think the metric should be updated.
   
   `GeoPersistentReplicator.msgOut` should be recorded before 
`producer#sendAsync`.
   
   ### Modifications
   
   Move `msgOut.recordEvent(headersAndPayload.readableBytes());` before 
`producer#sendAync`.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to