dragosvictor commented on code in PR #21682:
URL: https://github.com/apache/pulsar/pull/21682#discussion_r1418641046
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java:
##########
@@ -410,111 +426,240 @@ public boolean test(NamespaceBundle namespaceBundle) {
assertTrue(ex.getMessage().contains("cannot be transfer to same
broker"));
}
}
- @DataProvider(name = "isPersistentTopicTest")
- public Object[][] isPersistentTopicTest() {
- return new Object[][] { { true }, { false }};
+
+ @DataProvider(name = "isPersistentTopicSubscriptionTypeTest")
+ public Object[][] isPersistentTopicSubscriptionTypeTest() {
+ return new Object[][]{
+ {TopicDomain.persistent, SubscriptionType.Exclusive},
+ {TopicDomain.persistent, SubscriptionType.Shared},
+ {TopicDomain.persistent, SubscriptionType.Failover},
+ {TopicDomain.persistent, SubscriptionType.Key_Shared},
Review Comment:
The code stresses various parts of the consumer flow, I'd rather keep these
around to catch any potential regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
