mattisonchao commented on code in PR #21193:
URL: https://github.com/apache/pulsar/pull/21193#discussion_r1421853816
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/MessageDeduplication.java:
##########
@@ -493,6 +501,12 @@ public synchronized void purgeInactiveProducers() {
long minimumActiveTimestamp = System.currentTimeMillis() -
TimeUnit.MINUTES
.toMillis(pulsar.getConfiguration().getBrokerDeduplicationProducerInactivityTimeoutMinutes());
+ // if not enabled just clear all inactive producer record.
+ if (!isEnabled()) {
Review Comment:
Please add a meaningful comment here to explain the dynamic configuration
update problem. btw, maybe we can move the cleanup logic into `checkStatus`
logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
