BewareMyPower commented on PR #21714: URL: https://github.com/apache/pulsar/pull/21714#issuecomment-1853324847
I see the difference and why you added a `value` field to `CustomField` now. However, the [original proposal](https://github.com/apache/pulsar/blob/master/pip/pip-300.md) only mentioned the listener in the example code: ```java pulsarService.getBrokerService().registerConfigurationListener(myAuthIdKey, (newValue) -> { // The `myAuthIdKey` value has changed myAuthIdValue = String.valueOf(newValue); }); ``` From the **In Scope** section: > The goal of this PIP is to allow the pulsar-admin to update the values of customized configuration. It never mentioned anything related to the listener. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
