BewareMyPower commented on code in PR #20884:
URL: https://github.com/apache/pulsar/pull/20884#discussion_r1425043019
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -3356,13 +3367,24 @@ public void
unblockDispatchersOnUnAckMessages(List<PersistentDispatcherMultipleC
}
private static class ConfigField {
+ // field holds the pulsar dynamic configuration.
final Field field;
+
+ // customValue holds the external dynamic configuration.
+ String customValue;
Review Comment:
Should it be volatile?
```suggestion
volatile String customValue;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
