dragosvictor commented on code in PR #21789:
URL: https://github.com/apache/pulsar/pull/21789#discussion_r1435204037


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/PulsarTestClient.java:
##########
@@ -125,7 +125,7 @@ public CompletableFuture<ClientCnx> getConnection(String 
topic) {
             result.completeExceptionally(new IOException("New connections are 
rejected."));
             return result;
         } else {
-            return super.getConnection(topic, 
getCnxPool().genRandomKeyToSelectCon());
+            return super.getConnection(topic);

Review Comment:
   My thinking was to remove it since it's only used in the tests and it's not 
overloaded anywhere, thus we can simplify the code a bit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to