massakam commented on code in PR #377:
URL: https://github.com/apache/pulsar-client-cpp/pull/377#discussion_r1436381029


##########
lib/LogUtils.cc:
##########
@@ -25,6 +25,7 @@
 
 namespace pulsar {
 
+static std::atomic<LoggerFactory*> s_defaultLoggerFactory(new 
ConsoleLoggerFactory());

Review Comment:
   @BewareMyPower
   `s_loggerFactory` also has the same issue, right? `s_loggerFactory` used to 
be a static shared_ptr, but it seems that it was changed to its current type to 
avoid segfaults during process shutdown.
   https://github.com/apache/pulsar/pull/7132



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to