lhotari commented on code in PR #21853:
URL: https://github.com/apache/pulsar/pull/21853#discussion_r1444299909
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/PatternTopicsConsumerImplTest.java:
##########
@@ -620,13 +625,28 @@ public void testStartEmptyPatternConsumer() throws
Exception {
producer3.close();
}
- @Test(timeOut = testTimeout)
- public void testAutoSubscribePatterConsumerFromBrokerWatcher() throws
Exception {
- String key = "AutoSubscribePatternConsumer";
- String subscriptionName = "my-ex-subscription-" + key;
+ @DataProvider(name= "delayTypesOfWatchingTopics")
+ public Object[][] delayTypesOfWatchingTopics(){
+ return new Object[][]{
+ {true},
+ {false}
+ };
+ }
- Pattern pattern =
Pattern.compile("persistent://my-property/my-ns/pattern-topic.*");
- Consumer<byte[]> consumer = pulsarClient.newConsumer()
+ @Test(timeOut = testTimeout, dataProvider = "delayTypesOfWatchingTopics")
+ public void testAutoSubscribePatterConsumerFromBrokerWatcher(boolean
delayWatchingTopics) throws Exception {
+ final String key = "AutoSubscribePatternConsumer";
+ final String subscriptionName = "my-ex-subscription-" + key;
+ final Pattern pattern =
Pattern.compile("persistent://my-property/my-ns/pattern-topic.*");
+
+ PulsarClient client = null;
+ if (delayWatchingTopics) {
+ client = createDelayWatchTopicsClient();
Review Comment:
does this client ever get closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
