heesung-sn commented on code in PR #21854:
URL: https://github.com/apache/pulsar/pull/21854#discussion_r1445416147
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1870,10 +1872,14 @@ protected void handleAck(CommandAck ack) {
Consumer consumer = consumerFuture.getNow(null);
Subscription subscription = consumer.getSubscription();
if (subscription.getTopic().isTransferring()) {
+ PulsarService pulsar = getBrokerService().getPulsar();
// Message acks are silently ignored during topic transfer.
+ long ignoredAckCount = ack.getMessageIdsCount();
+ var ignoredAckTotalCount =
ExtensibleLoadManagerImpl.get(pulsar).getIgnoredAckCount().
Review Comment:
> the topic transferring flag can only be set when the Extensible Load
Manager is enabled.
yes, since this transferring flag is set by ExtensibleLoadManagerImpl.
checking if ExtensibleLoadManagerImpl is enabled here seems redundant,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
