asafm commented on code in PR #21873:
URL: https://github.com/apache/pulsar/pull/21873#discussion_r1447404252
##########
pip/pip-330.md:
##########
@@ -0,0 +1,43 @@
+# PIP-330: getMessageById gets all messages
+
+# Motivation
+
+The `org.apache.pulsar.client.admin.Topics` provides
`getMessageById(java.lang.String, long, long)` method to get the
+message, which returns one message. If the message id refers to a batch
message, we only can get the first message, not
+all messages.
+
+This behavior affects our analysis of messages by the message id.
+
+# Goals
+
+## In Scope
+
+Add a method that returns all messages by message id to the
`org.apache.pulsar.client.admin.Topics` interface.
Review Comment:
The server returns the entry, and the client extract the first message and
throws the rest?
##########
pip/pip-330.md:
##########
@@ -0,0 +1,43 @@
+# PIP-330: getMessageById gets all messages
+
+# Motivation
+
+The `org.apache.pulsar.client.admin.Topics` provides
`getMessageById(java.lang.String, long, long)` method to get the
+message, which returns one message. If the message id refers to a batch
message, we only can get the first message, not
+all messages.
+
+This behavior affects our analysis of messages by the message id.
+
+# Goals
+
+## In Scope
+
+Add a method that returns all messages by message id to the
`org.apache.pulsar.client.admin.Topics` interface.
+
+# Detailed Design
+
+## Design & Implementation Details
+
+Add `getMessageById(java.lang.String, java.lang.String)` to
`org.apache.pulsar.client.admin.Topics` interface:
+
+```java
+public interface Topics {
+ List<Message<byte[]>> getMessageById(String topic, String messageId)
throws PulsarAdminException;
Review Comment:
Can you please make the `String messageId` not a string, and break it down
as instructed below to ledgerId, entryId and batchIndex?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
