heesung-sn commented on code in PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#discussion_r1450033138
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1600,7 +1667,14 @@ public void closeFailed(ManagedLedgerException
exception, Object ctx) {
closeFuture.completeExceptionally(exception);
return null;
});
-
+ if (!disconnectClients) {
+ FutureUtil.completeAfter(closeFutures.notDisconnectClients,
closeFuture);
+ } else {
+ FutureUtil.completeAfter(closeFutures.notDisconnectClients,
closeFuture);
+ FutureUtil.completeAfter(closeFutures.notWaitDisconnectClients,
closeFuture);
+ FutureUtil.completeAfterAll(closeFutures.waitDisconnectClients,
closeFuture,
+ FutureUtil.waitForAll(futures));
Review Comment:
Why do we wait for futures here? Dont we already have this logic handled at
line 1639?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
