(pulsar) branch branch-3.2 updated: [improve][broker] Improve NamespaceUnloadStrategy error message (#21880)

[technoboy]

This is an automated email from the ASF dual-hosted git repository.

technoboy pushed a commit to branch branch-3.2
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/branch-3.2 by this push:
     new 50925b2ed1f [improve][broker] Improve NamespaceUnloadStrategy error 
message (#21880)
50925b2ed1f is described below

commit 50925b2ed1f1bb301d3534b54aa5b34f81932145
Author: Dragos Misca <dragosvic...@users.noreply.github.com>
AuthorDate: Wed Jan 10 16:03:40 2024 -0800

    [improve][broker] Improve NamespaceUnloadStrategy error message (#21880)
---
 .../broker/loadbalance/extensions/scheduler/UnloadScheduler.java     | 5 ++---
 .../pulsar/proxy/server/ProxyWithExtensibleLoadManagerTest.java      | 2 ++
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/UnloadScheduler.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/UnloadScheduler.java
index d6c754c90fc..218f57932a5 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/UnloadScheduler.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/UnloadScheduler.java
@@ -219,9 +219,8 @@ public class UnloadScheduler implements 
LoadManagerScheduler {
                     Thread.currentThread().getContextClassLoader());
             log.info("Created namespace unload strategy:{}", 
unloadStrategy.getClass().getCanonicalName());
         } catch (Exception e) {
-            log.error("Error when trying to create namespace unload strategy: 
{}",
-                    conf.getLoadBalancerLoadPlacementStrategy(), e);
-            log.error("create namespace unload strategy failed. using 
TransferShedder instead.");
+            log.error("Error when trying to create namespace unload strategy: 
{}. Using {} instead.",
+                    conf.getLoadBalancerLoadSheddingStrategy(), 
TransferShedder.class.getCanonicalName(), e);
             unloadStrategy = new TransferShedder();
         }
         unloadStrategy.initialize(pulsar);
diff --git 
a/pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyWithExtensibleLoadManagerTest.java
 
b/pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyWithExtensibleLoadManagerTest.java
index 3a787a8b359..147c5396520 100644
--- 
a/pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyWithExtensibleLoadManagerTest.java
+++ 
b/pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyWithExtensibleLoadManagerTest.java
@@ -47,6 +47,7 @@ import org.apache.pulsar.broker.PulsarService;
 import org.apache.pulsar.broker.ServiceConfiguration;
 import org.apache.pulsar.broker.authentication.AuthenticationService;
 import 
org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl;
+import 
org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder;
 import org.apache.pulsar.client.admin.PulsarAdminException;
 import org.apache.pulsar.client.api.PulsarClient;
 import org.apache.pulsar.client.api.PulsarClientException;
@@ -97,6 +98,7 @@ public class ProxyWithExtensibleLoadManagerTest extends 
MultiBrokerBaseTest {
         config.setLoadBalancerInFlightServiceUnitStateWaitingTimeInMillis(5 * 
1000);
         config.setLoadBalancerServiceUnitStateMonitorIntervalInSeconds(1);
         
config.setLoadManagerClassName(ExtensibleLoadManagerImpl.class.getName());
+        
config.setLoadBalancerLoadSheddingStrategy(TransferShedder.class.getName());
         config.setLoadBalancerSheddingEnabled(false);
         return config;
     }