lhotari commented on code in PR #21896:
URL: https://github.com/apache/pulsar/pull/21896#discussion_r1452296256
##########
distribution/server/src/assemble/LICENSE.bin.txt:
##########
@@ -478,6 +480,7 @@ The Apache Software License, Version 2.0
- io.vertx-vertx-web-4.3.8.jar
- io.vertx-vertx-web-common-4.3.8.jar
- io.vertx-vertx-grpc-4.3.5.jar
+ - io.vertx-vertx-grpc-4.5.1.jar
Review Comment:
Mixing vertx libraries versions doesn't look good.
##########
distribution/server/src/assemble/LICENSE.bin.txt:
##########
@@ -436,6 +436,7 @@ The Apache Software License, Version 2.0
- io.grpc-grpc-rls-1.55.3.jar
- io.grpc-grpc-servlet-1.55.3.jar
- io.grpc-grpc-servlet-jakarta-1.55.3.jar
+ - io.grpc-grpc-util-1.60.0.jar
Review Comment:
Mixing grpc library versions doesn't look good. grpc version is currently
coupled to protobuf version and also to bookkeeper version so we cannot safely
upgrade protobuf. (see thread
https://lists.apache.org/thread/s9g6w31vtwzgqf162hhlcr2nx3y68gv5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
