hanmz commented on code in PR #21907:
URL: https://github.com/apache/pulsar/pull/21907#discussion_r1454447656
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/UniformLoadShedder.java:
##########
@@ -137,7 +137,7 @@ public Multimap<String, String>
findBundlesForUnloading(final LoadData loadData,
brokersData.get(msgRateOverloadedBroker.getValue()).getLocalData();
if (overloadedBrokerData.getBundles().size() > 1
&& (msgRateRequiredFromUnloadedBundles.getValue() >=
conf.getMinUnloadMessage())) {
- // Sort bundles by throughput, then pick the bundle which
can help to reduce load uniformly with
+ // Sort bundles by msgRate, then pick the bundle which can
help to reduce load uniformly with
Review Comment:
Oh, this is not to fix typos, but because the content in the comments is
different from the actual logic. Here they are sorted according to msgRate.
Here I fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
