thetumbled opened a new pull request, #21908:
URL: https://github.com/apache/pulsar/pull/21908
### Motivation
Configuratioin `brokerServiceCompactionPhaseOneLoopTimeInSeconds` is defined
as the total timeout of phase one.
```
@FieldContext(
category = CATEGORY_SERVER,
doc = "Timeout for the compaction phase one loop, If the
execution time of the compaction "
+ "phase one loop exceeds this time, the compaction will
not proceed."
)
private long brokerServiceCompactionPhaseOneLoopTimeInSeconds = 30;
```
But current implementation just set a timeout for a single message read
operation, which is different with the meaning of
`brokerServiceCompactionPhaseOneLoopTimeInSeconds` and will result into
thousands of timer tasks be scheduled and cancelled in the scheduler because we
may iterate many messages.
### Modifications
Set a timer task for the tatol phase one.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
