Demogorgon314 commented on code in PR #21894:
URL: https://github.com/apache/pulsar/pull/21894#discussion_r1455279089
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java:
##########
@@ -141,7 +141,9 @@ public void getLeaderBroker(@Suspended final AsyncResponse
asyncResponse) {
validateSuperUserAccessAsync().thenAccept(__ -> {
LeaderBroker leaderBroker =
pulsar().getLeaderElectionService().getCurrentLeader()
.orElseThrow(() -> new
RestException(Status.NOT_FOUND, "Couldn't find leader broker"));
- BrokerInfo brokerInfo =
BrokerInfo.builder().serviceUrl(leaderBroker.getServiceUrl()).build();
+ BrokerInfo brokerInfo = BrokerInfo.builder()
+ .serviceUrl(leaderBroker.getServiceUrl())
+
.lookupServiceAddress(leaderBroker.getLookupServiceAddress()).build();
Review Comment:
Since the lookup service address is the address used in the load manager to
identify the broker, maybe we can name it `brokerId`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
