BewareMyPower commented on code in PR #383:
URL: https://github.com/apache/pulsar-client-cpp/pull/383#discussion_r1458188250
##########
lib/RetryableOperationCache.h:
##########
@@ -40,8 +41,8 @@ class RetryableOperationCache : public
std::enable_shared_from_this<RetryableOpe
explicit PassKey() {}
};
- RetryableOperationCache(ExecutorServiceProviderPtr executorProvider, int
timeoutSeconds)
- : executorProvider_(executorProvider), timeoutSeconds_(timeoutSeconds)
{}
+ RetryableOperationCache(ExecutorServiceProviderPtr executorProvider,
std::chrono::nanoseconds timeoutMs)
Review Comment:
Oh the name is wrong. It should be nanoseconds. I will address it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
