coderzc commented on code in PR #21917:
URL: https://github.com/apache/pulsar/pull/21917#discussion_r1458334062


##########
pulsar-broker/src/main/java/org/apache/pulsar/compaction/TwoPhaseCompactor.java:
##########
@@ -467,4 +467,8 @@ private static class PhaseOneResult {
     public long getPhaseOneLoopReadTimeoutInSeconds() {
         return phaseOneLoopReadTimeout.getSeconds();
     }
+
+    public void setTopicCompactionRetainNullKey(boolean 
topicCompactionRetainNullKey) {
+        this.topicCompactionRetainNullKey = topicCompactionRetainNullKey;
+    }

Review Comment:
   Don't expose this method, we can change broker.conf.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to