hrzzzz commented on code in PR #21915:
URL: https://github.com/apache/pulsar/pull/21915#discussion_r1459390357
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2789,29 +2789,22 @@ public void skipNonRecoverableLedger(final long
ledgerId){
if (ledgerInfo == null) {
return;
}
- lock.writeLock().lock();
log.warn("[{}] [{}] Since the ledger [{}] is lost and the
autoSkipNonRecoverableData is true, this ledger will"
+ " be auto acknowledge in subscription", ledger.getName(),
name, ledgerId);
- try {
- for (int i = 0; i < ledgerInfo.getEntries(); i++) {
- if (!individualDeletedMessages.contains(ledgerId, i)) {
Review Comment:
https://github.com/apache/pulsar/blob/74f1cd51380b71c77d2f33ecb5830eab19ecb6f3/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java#L2280-L2291
Yes, because the condition will be checked again in the asyncDelete method,
it can be removed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
