lhotari commented on PR #21015:
URL: https://github.com/apache/pulsar/pull/21015#issuecomment-1900998011

   #21894 makes further improvements in this area and replace 
"lookupServiceAddress" with "brokerId" and uses it consistenly across the code 
base.
   
   @Technoboy- what was the reason to not cherry-pick this fix to branch-3.0 
and branch-3.1 ? I noticed that you had reverted the change to branch-3.1 . The 
reason I'm asking is that I am cherry-picking #21894 to branch-3.0 and 
branch-3.1 and I noticed that tests fail on branch-3.0 . The reason for this is 
that in master branch, there are different test configuration for tests due to 
changes made in this PR.
   I already cherry-picked #21633 to branch-3.0 and branch-3.1 since that's a 
bug fix too and without the changes there are some additional merge conflicts 
when cherry-picking #21894 .
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to