lhotari commented on code in PR #21915:
URL: https://github.com/apache/pulsar/pull/21915#discussion_r1461392083
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2793,30 +2794,23 @@ public void skipNonRecoverableLedger(final long
ledgerId){
if (ledgerInfo == null) {
return;
}
- lock.writeLock().lock();
log.warn("[{}] [{}] Since the ledger [{}] is lost and the
autoSkipNonRecoverableData is true, this ledger will"
+ " be auto acknowledge in subscription", ledger.getName(),
name, ledgerId);
- try {
- for (int i = 0; i < ledgerInfo.getEntries(); i++) {
- if (!individualDeletedMessages.contains(ledgerId, i)) {
- asyncDelete(PositionImpl.get(ledgerId, i), new
AsyncCallbacks.DeleteCallback() {
- @Override
- public void deleteComplete(Object ctx) {
- // ignore.
- }
+ asyncDelete(() -> LongStream.range(0, ledgerInfo.getEntries())
Review Comment:
Creating a PositionImpl object is a very light operation. Especially in the
streaming approach where they live for a very short time, single loop instead
of being created beforehand.
Adding a deletion check is the position has been created is most likely more
expensive than creating the object. The deletion check is any ways done in the
asyncDelete method and it's extra work to have the pre-check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
