coderzc commented on PR #21187: URL: https://github.com/apache/pulsar/pull/21187#issuecomment-1905219220
> To avoid skipping the remaining data in the compacted ledger after rewind, we need to record readCompacted to cursor.properties and just rewind to the next message of the mark delete position instead of resetting the read position to the next valid position of the original topic. > Is it better to fix this one by a separate PR? It's a potential data loss issue, doesn't seem related to the PR title. And which test can reproduce this issue? @codelipenghui Because consumer is always read from the earliest position before applying this change, we can't reproduce `skipping the remaining data in the compacted ledger after rewind` issue, it will happen after changing the `readFromEarliest` condition,so I'm not sure if we should split it into two PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
