codelipenghui commented on code in PR #21187:
URL: https://github.com/apache/pulsar/pull/21187#discussion_r1464255148
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2519,7 +2525,8 @@ public Position getPersistentMarkDeletedPosition() {
public void rewind() {
lock.writeLock().lock();
try {
- PositionImpl newReadPosition =
ledger.getNextValidPosition(markDeletePosition);
+ PositionImpl newReadPosition = isCursorReadFromCompacted() ?
markDeletePosition.getNext() :
+ ledger.getNextValidPosition(markDeletePosition);
Review Comment:
@coderzc I see.
After checking the changes again. It looks like we don't need to persist the
`readCompacted`? If depends on the consumer settings. We only need to set the
`readCompacted` when new consumer connected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
