frankjkelly commented on code in PR #439:
URL: https://github.com/apache/pulsar-helm-chart/pull/439#discussion_r1465208892


##########
README.md:
##########
@@ -162,12 +162,29 @@ verified in some [tests](./.ci/clusters).
 
 ## Grafana Dashboards
 
-The Apache Pulsar Helm Chart uses the `kube-prometheus-stack` Helm Chart to 
deploy Grafana. Dashboards are loaded via a Kubernetes `ConfigMap`. Please see 
their documentation for loading those dashboards.
+The Apache Pulsar Helm Chart uses the `kube-prometheus-stack` Helm Chart to 
deploy Grafana.
 
-The `apache/pulsar` GitHub repo contains some dashboards 
[here](https://github.com/apache/pulsar/tree/master/grafana).
+There are several ways to configure Grafana dashboards. The default 
`values.yaml` comes examples of Pulsar dashboards which 

Review Comment:
   Missing word `comes with examples`?



##########
README.md:
##########
@@ -162,12 +162,29 @@ verified in some [tests](./.ci/clusters).
 
 ## Grafana Dashboards
 
-The Apache Pulsar Helm Chart uses the `kube-prometheus-stack` Helm Chart to 
deploy Grafana. Dashboards are loaded via a Kubernetes `ConfigMap`. Please see 
their documentation for loading those dashboards.
+The Apache Pulsar Helm Chart uses the `kube-prometheus-stack` Helm Chart to 
deploy Grafana.
 
-The `apache/pulsar` GitHub repo contains some dashboards 
[here](https://github.com/apache/pulsar/tree/master/grafana).
+There are several ways to configure Grafana dashboards. The default 
`values.yaml` comes examples of Pulsar dashboards which 
+get downloaded from 
https://github.com/streamnative/apache-pulsar-grafana-dashboard by URL.

Review Comment:
   Should this be a hyperlink e.g. `[label][https://xxxx]` for consistency with 
the below?



##########
README.md:
##########
@@ -162,12 +162,29 @@ verified in some [tests](./.ci/clusters).
 
 ## Grafana Dashboards
 
-The Apache Pulsar Helm Chart uses the `kube-prometheus-stack` Helm Chart to 
deploy Grafana. Dashboards are loaded via a Kubernetes `ConfigMap`. Please see 
their documentation for loading those dashboards.
+The Apache Pulsar Helm Chart uses the `kube-prometheus-stack` Helm Chart to 
deploy Grafana.
 
-The `apache/pulsar` GitHub repo contains some dashboards 
[here](https://github.com/apache/pulsar/tree/master/grafana).
+There are several ways to configure Grafana dashboards. The default 
`values.yaml` comes examples of Pulsar dashboards which 
+get downloaded from 
https://github.com/streamnative/apache-pulsar-grafana-dashboard by URL.
 
-### Third Party Dashboards
+Dashboards can be configured in `values.yaml` or by adding `ConfigMap` items 
with label `grafana_dashboard: "1"`.

Review Comment:
   Missing word `with the label`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to