lhotari commented on code in PR #21966:
URL: https://github.com/apache/pulsar/pull/21966#discussion_r1466052609


##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarStateTest.java:
##########
@@ -480,6 +480,7 @@ private void queryState(String functionName, String key, 
int amount)
             "--key", key
         );
         assertTrue(result.getStdout().contains("\"numberValue\": " + amount));
+        assertTrue(result.getStdout().contains("\"version\": " + version));

Review Comment:
   It would be better to parse the JSON and validate that it doesn't contain 
extra keys such as `"stringValue": 
"\u0000\u0000\u0000\u0000\u0000\u0000\u0000\n"` which was observed in the 
release candidate validation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to