Jason918 commented on code in PR #21939:
URL: https://github.com/apache/pulsar/pull/21939#discussion_r1467350382
##########
conf/broker.conf:
##########
@@ -1844,4 +1844,7 @@ brokerInterceptorsDirectory=./interceptors
brokerInterceptors=
# Enable or disable the broker interceptor, which is only used for testing for
now
-disableBrokerInterceptors=true
\ No newline at end of file
+disableBrokerInterceptors=true
+
+# List of interceptors for entry metadata
Review Comment:
Add a note to explain the risk of removing this config?
##########
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java:
##########
@@ -1697,7 +1697,7 @@ public static ByteBuf addBrokerEntryMetadata(ByteBuf
headerAndPayload,
// | BROKER_ENTRY_METADATA_MAGIC_NUMBER | BROKER_ENTRY_METADATA_SIZE
| BROKER_ENTRY_METADATA |
// | 2 bytes | 4 bytes
| BROKER_ENTRY_METADATA_SIZE bytes |
- BrokerEntryMetadata brokerEntryMetadata = BROKER_ENTRY_METADATA.get();
+ BrokerEntryMetadata brokerEntryMetadata =
BROKER_ENTRY_METADATA.get().clear();
Review Comment:
Any known cases that this change is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
