lhotari commented on code in PR #452:
URL: https://github.com/apache/pulsar-helm-chart/pull/452#discussion_r1472750915
##########
charts/pulsar/templates/function-worker-rbac.yaml:
##########
@@ -17,6 +17,7 @@
# under the License.
#
+{{- if .Values.rbac.enabled }}
Review Comment:
Adding this condition will break Pulsar Functions support. It is mandatory
when `.Values.components.functions` is enabled. That's why adding this
condition is problematic. Perhaps we instead need to clarify the documentation
of `rbac.enabled` and explain that RBAC will be always configured for Pulsar
Functions regardless of `rbac.enabled`.
##########
charts/pulsar/values.yaml:
##########
@@ -930,7 +930,7 @@ functions:
component: functions-worker
useBookieAsStateStore: false
## Pulsar: Functions Worker ClusterRole or Role
- ## templates/broker-rbac.yaml
+ ## templates/function-worker-rbac.yaml
Review Comment:
In the current Pulsar Helm Chart, there isn't a separate `function-worker`
pod. The `function-worker` role is handled by the broker. Perhaps we should
rename the file to be `broker-function-worker-rbac.yaml` to indicate this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
