poorbarcode commented on PR #22020: URL: https://github.com/apache/pulsar/pull/22020#issuecomment-1926197371
> According to the method signature, we should return true when the transaction is added to the tracker. > ``` > /** > * Add a txnID to the tracker. > * > * @param sequenced > * the sequenced > * @param timeout > * the absolute timestamp for transaction timeout > * > * @return true if the transaction was added to the tracker or false if had timed out > */ > CompletableFuture<Boolean> addTransaction(long sequenceId, long timeout); > ``` > But actually, we return false for any cases. You changed the definition to `void addTransation()`, it is not matches with the Motivation, please correct it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
