dragosvictor commented on code in PR #22010:
URL: https://github.com/apache/pulsar/pull/22010#discussion_r1481903197


##########
pulsar-broker/pom.xml:
##########
@@ -470,6 +472,11 @@
       <version>${project.version}</version>
     </dependency>
 
+    <dependency>
+      <groupId>io.rest-assured</groupId>

Review Comment:
   I had to move `PrometheusMetricsClient` to `pulsar-broker-common` for it to 
be available in `pulsar-otel-integration` without causing cyclic dependencies 
otherwise (`pulsar-otel-integration` <---> `pulsar-broker`). Doing so, 
`rest-assured` gets excluded from the broker, causing test issues, so I had to 
include it explicitly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to