visortelle commented on code in PR #789:
URL: https://github.com/apache/pulsar-site/pull/789#discussion_r1488412799


##########
src/components/pages/ArticlesPage/Cards/Cards.tsx:
##########
@@ -0,0 +1,36 @@
+import React from "react";
+import s from './Cards.module.css';
+import * as data from '@site/data/resources';
+
+const Card: React.FC<data.Resource> = (props) => {
+  let tagsArray = new Array();
+  if(props.tags) tagsArray = props.tags.split(", ");

Review Comment:
   It probably makes sense to change the `Resource['tags']` type from `string` 
to `string[]`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to