heesung-sn commented on code in PR #22055:
URL: https://github.com/apache/pulsar/pull/22055#discussion_r1490251530
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -2205,7 +2205,7 @@ public void updateRates(NamespaceStats nsStats,
NamespaceBundleStats bundleStats
// Start subscription stats
topicStatsStream.startObject("subscriptions");
- nsStats.subsCount += subscriptions.size();
+ nsStats.subsCount += (int) (subscriptions.size());
Review Comment:
nit: do we need (int)? seems like subscriptions.size() is already long.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java:
##########
@@ -183,7 +183,7 @@ public synchronized void updateStats(
topicStatsStream.endObject();
});
- brokerStats.bundleCount += bundles.size();
+ brokerStats.bundleCount += (int) bundles.size();
Review Comment:
nit: do we need `(int)`? seems like bundles.size() is already long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
