lhotari opened a new pull request, #462: URL: https://github.com/apache/pulsar-helm-chart/pull/462
Fixes #56 ### Motivation - See #56. ### Modifications - Remove the `PF_functionRuntimeFactoryConfigs_changeConfigMap` configuration and the config map specified in `templates/function-worker-configmap.yaml` that is used for the `changeConfigMap`. The `changeConfigMap` is a feature that has never been completed and is therefore just causing confusion. The function worker is configured with keys starting with `PF_` in `.Values.broker.configData`. Keys in `function_worker.yml` can be overridden/added using the `PF_` prefix, with `_` serving as the key path separator. ### Additional context about the `changeConfigMap` feature. The keys in the config map get applied in code with a timer, ever 5 minutes with this code https://github.com/apache/pulsar/blob/613a77100226628d8685d34260685d2df2b405ae/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java#L408-L422 . The values get applied directly to the KubernetesRuntimeFactory instance. The solution is buggy and will only work for String fields since there is no value conversion logic. Another problem is that initially it will start with the default values and override after running for 5 minutes. Therefore it seems like a useless solution. There's no need to support such features in the Apache Pulsar Helm chart. ### Verifying this change - [ ] Make sure that the change passes the CI checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
