liangyepianzhou opened a new pull request, #22203:
URL: https://github.com/apache/pulsar/pull/22203

   ### Motivation
   When the geo-replication is enabled at the namespace level, the partition 
topic could be created in the remote clusters when it is created at the local 
cluster.
   
https://github.com/apache/pulsar/blob/207335a449f2bc9cdf6782c67f93f8c2fb267271/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java#L610-L612
   
   However, if the geo-replication is enabled at the topic level, the partition 
topic cannot be created in the remote clusters when created at the local 
cluster. The non-partition topics will be auto-created in the remote clusters 
when the topic starts replicators and builds producers. It is confusing that 
the topic is partitioned in the local cluster and non-partition in the remote 
cluster.
   
   ### Modifications
   
   Create partition topics when updating topic policies. 
   For the deleting policies when disabling geo-replication at the topic level, 
there are two solutions:
   1. Delete all the topics in the remote clusters
   2. Use inactive topic policies to clear the useless topics in the remote 
clusters.
   I prefer to the solution 2, so this PR does not include the modification of 
deleting topics.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads 
(10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions 
will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since 
the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed 
in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments 
have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to