dragosvictor commented on code in PR #22058:
URL: https://github.com/apache/pulsar/pull/22058#discussion_r1513100646
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -153,35 +151,37 @@ public class NamespaceService implements AutoCloseable {
private final RedirectManager redirectManager;
- @PulsarDeprecatedMetric(newMetricName =
"pulsar.broker.lookup.request.duration")
+ public static final String LOOKUP_REQUEST_DURATION_METRIC_NAME =
"pulsar.broker.request.topic.lookup.duration";
+
+ private static final AttributeKey<String> PULSAR_LOOKUP_RESPONSE_TYPE =
+ AttributeKey.stringKey("pulsar.lookup.response.type");
Review Comment:
Missed out on that, thanks for finding it! Fixed.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -201,7 +201,7 @@ public NamespaceService(PulsarService pulsar) {
this.redirectManager = new RedirectManager(pulsar);
this.lookupLatencyHistogram = pulsar.getOpenTelemetry().getMeter()
- .histogramBuilder("pulsar.broker.lookup.request.duration")
+ .histogramBuilder(LOOKUP_REQUEST_DURATION_METRIC_NAME)
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
