nodece commented on code in PR #22209:
URL: https://github.com/apache/pulsar/pull/22209#discussion_r1516379813


##########
pulsar-cli-utils/src/main/java/org/apache/pulsar/cli/ValueValidationUtil.java:
##########
@@ -27,31 +26,31 @@ public class ValueValidationUtil {
 
     public static void maxValueCheck(String paramName, long value, long 
maxValue) {
         if (value > maxValue) {
-            throw new ParameterException(paramName + " cannot be bigger than 
<" + maxValue + ">!");
+            throw new IllegalArgumentException(paramName + " cannot be bigger 
than <" + maxValue + ">!");

Review Comment:
   To eliminate the jcommander dependency, this must be done.
   
   ParameterException was provided by the jcommander.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to