merlimat commented on code in PR #22179:
URL: https://github.com/apache/pulsar/pull/22179#discussion_r1517201683


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -386,7 +402,29 @@ protected ConsumerImpl(PulsarClientImpl client, String 
topic, ConsumerConfigurat
 
         topicNameWithoutPartition = topicName.getPartitionedTopicName();
 
+        InstrumentProvider ip = client.instrumentProvider();
+        consumersOpenedCounter = 
ip.newCounter("pulsar.client.consumer.opened", Unit.Sessions,
+                "Counter of sessions opened", topic, Attributes.empty());

Review Comment:
   I'm not sure I understand the comment. The counter here is getting tagged 
with tenant/namespace/topic/partition attributes. By default, we only emit 
`tenant` and `namespace` and user would be able to select the desired level



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to