merlimat commented on code in PR #22178:
URL: https://github.com/apache/pulsar/pull/22178#discussion_r1520081179
##########
pip/pip-342 OTel client metrics support.md:
##########
@@ -166,36 +122,51 @@ this is the proposed initial set of metrics to export.
Additional metrics could be added later on, though it's better to start with
the set of most important metrics
and then evaluate any missing information.
-| OTel metric name | Type | Unit |
Description
|
-|-------------------------------------------------|-----------|-------------|------------------------------------------------------------------------------------------------|
-| `pulsar.client.connections.opened` | Counter | connections |
Counter of connections opened
|
-| `pulsar.client.connections.closed` | Counter | connections |
Counter of connections closed
|
-| `pulsar.client.connections.failed` | Counter | connections |
Counter of connections establishment failures
|
-| `pulsar.client.session.opened` | Counter | sessions |
Counter of sessions opened. `type="producer"` or `consumer`
|
-| `pulsar.client.session.closed` | Counter | sessions |
Counter of sessions closed. `type="producer"` or `consumer`
|
-| `pulsar.client.received` | Counter | messages |
Number of messages received
|
-| `pulsar.client.received` | Counter | bytes |
Number of bytes received
|
-| `pulsar.client.consumer.preteched.messages` | Gauge | messages |
Number of messages currently sitting in the consumer pre-fetch queue
|
-| `pulsar.client.consumer.preteched` | Gauge | bytes |
Total number of bytes currently sitting in the consumer pre-fetch queue
|
-| `pulsar.client.consumer.ack` | Counter | messages |
Number of ack operations
|
-| `pulsar.client.consumer.nack` | Counter | messages |
Number of negative ack operations
|
-| `pulsar.client.consumer.dlq` | Counter | messages |
Number of messages sent to DLQ
|
-| `pulsar.client.consumer.ack.timeout` | Counter | messages |
Number of ack timeouts events
|
-| `pulsar.client.producer.latency` | Histogram | seconds |
Publish latency experienced by the application, includes client batching time
|
-| `pulsar.client.producer.rpc.latency` | Histogram | seconds |
Publish RPC latency experienced internally by the client when sending data to
receiving an ack |
-| `pulsar.client.producer.published` | Counter | bytes |
Bytes published
|
-| `pulsar.client.producer.pending.messages.count` | Gauge | messages |
Pending messages for this producer
|
-| `pulsar.client.producer.pending.count` | Gauge | bytes |
Pending bytes for this producer
|
+| OTel metric name | Type | Unit |
Description
|
+|-------------------------------------------------|-----------|-------------|-------------------------------------------------------------------------------------------------------------------------------------------|
+| `pulsar.client.connection.opened` | Counter | connections |
The number of connections opened
|
Review Comment:
I agree that it should be included in as part of the documentation. As part
of this proposal, it's explained that where appropriate, the metrics are going
to be tagged with tenant/topic/etc labal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
