dao-jun commented on code in PR #22221: URL: https://github.com/apache/pulsar/pull/22221#discussion_r1524223866
########## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java: ########## @@ -200,7 +210,7 @@ public void addComplete(int rc, final LedgerHandle lh, long entryId, Object ctx) lh == null ? -1 : lh.getId(), entryId, dataLength, rc); } - if (rc != BKException.Code.OK) { + if (rc != BKException.Code.OK || timeoutTriggered.isTrue()) { Review Comment: Maybe some addOps just still in the executor queue, and even not executed, it is reasonable to switch to a new ledger? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org