lhotari commented on PR #22279: URL: https://github.com/apache/pulsar/pull/22279#issuecomment-2004253512
> @lhotari This PR is merged too quickly without a 2nd review. After revisiting the code, I found the double-checked locking is unnecessary. @BewareMyPower We don't have a policy that there should be a 2nd review. This PR didn't contain any risky changes and wasn't harmful at all and that's why I merged. It's better to keep on moving instead of optimizing for perfect PRs. The resolution that you have done is a good one: opening another PR with follow-up changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
