crossoverJie commented on code in PR #22303: URL: https://github.com/apache/pulsar/pull/22303#discussion_r1530653734
########## pulsar-testclient/src/main/java/org/apache/pulsar/testclient/LoadSimulationClient.java: ########## @@ -170,19 +170,19 @@ public void start() throws Exception { } } - // JCommander arguments for starting a LoadSimulationClient. - @Parameters(commandDescription = "Simulate client load by maintaining producers and consumers for topics.") + // picocli arguments for starting a LoadSimulationClient. + @Command(description = "Simulate client load by maintaining producers and consumers for topics.") Review Comment: Done. ########## pulsar-testclient/src/main/java/org/apache/pulsar/testclient/CmdGenerateDocumentation.java: ########## @@ -18,46 +18,47 @@ */ package org.apache.pulsar.testclient; -import com.beust.jcommander.JCommander; -import com.beust.jcommander.Parameter; -import com.beust.jcommander.ParameterDescription; -import com.beust.jcommander.ParameterException; -import com.beust.jcommander.Parameters; import java.lang.reflect.Constructor; import java.util.ArrayList; +import java.util.Arrays; import java.util.LinkedHashMap; import java.util.List; import java.util.Map; import lombok.extern.slf4j.Slf4j; +import picocli.CommandLine; +import picocli.CommandLine.Command; +import picocli.CommandLine.Option; +import picocli.CommandLine.ParameterException; @Slf4j public class CmdGenerateDocumentation { - @Parameters(commandDescription = "Generate documentation automatically.") + @Command(description = "Generate documentation automatically.") Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org