poorbarcode commented on code in PR #22284:
URL: https://github.com/apache/pulsar/pull/22284#discussion_r1531479154
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -4459,9 +4459,10 @@ private void cancelScheduledTasks() {
@Override
public boolean checkInactiveLedgerAndRollOver() {
- long currentTimeMs = System.currentTimeMillis();
- if (currentLedgerEntries > 0 && inactiveLedgerRollOverTimeMs > 0 &&
currentTimeMs > (lastAddEntryTimeMs
- + inactiveLedgerRollOverTimeMs)) {
+ if (factory.isMetadataServiceAvailable()
Review Comment:
Could you add a test to confirm that the broker will not trigger a ledger
rollover when the metadata service is not available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
