poorbarcode commented on code in PR #22182: URL: https://github.com/apache/pulsar/pull/22182#discussion_r1532464775
########## pip/pip-344.md: ########## @@ -0,0 +1,87 @@ +# PIP-344: Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName) + +# Background knowledge + +**Topic auto-creation** +- The partitioned topic auto-creation is dependent on `pulsarClient.getPartitionsForTopic` + - It triggers partitioned metadata creation by `pulsarClient.getPartitionsForTopic` + - And triggers the topic partition creation by producers' registration and consumers' registration. Review Comment: > What do you mean here? I don't think the partitioned topic auto-creation is dependent on PulsarClient.getPartitionsForTopic. The flow of partitioned topic creation is like below: - `PulsarClient.getPartitionsForTopic`: at this step, the partitioned topic metadata will be created. - Start `ProducerImpl` for each partition: at this step, it will not trigger a partitioned topic metadata creation even if it does not exist. > From the following description, it seems that the PulsarClient.getPartitionsForTopic API could create the partition metadata automatically. Correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
