sijie commented on a change in pull request #4738: [Transaction][buffer] Add
basic operation of transaction
URL: https://github.com/apache/pulsar/pull/4738#discussion_r305668359
##########
File path:
pulsar-transaction/buffer/src/main/java/org/apache/pulsar/transaction/buffer/impl/InMemTransactionBuffer.java
##########
@@ -79,6 +81,41 @@ public int numEntries() {
}
}
+ @Override
+ public long committedAtLedgerId() {
+ return committedAtLedgerId;
+ }
+
+ @Override
+ public long committedAtEntryId() {
+ return committedAtEntryId;
+ }
+
+ @Override
+ public long lastSequenceId() {
+ return entries.lastKey();
+ }
+
+ @Override
+ public CompletableFuture<SortedMap<Long, Position>> readEntries(int
num, long startSequenceId) {
+ return FutureUtil.failedFuture(new
UnsupportedOperationException());
+ }
+
+ @Override
+ public CompletableFuture<Void> appendEntry(long sequenceId, Position
position) {
+ return FutureUtil.failedFuture(new
UnsupportedOperationException());
+ }
+
+ @Override
+ public CompletableFuture<TransactionMeta> commitTxn(long
committedAtLedgerId, long committedAtEntryId) {
Review comment:
Please wrap `commitAt` and implement the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
