poorbarcode commented on code in PR #21995:
URL: https://github.com/apache/pulsar/pull/21995#discussion_r1540415191
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4634,7 +4634,7 @@ protected void internalGetLastMessageId(AsyncResponse
asyncResponse, boolean aut
});
}).exceptionally(ex -> {
// If the exception is not redirect exception we need to
log it.
- if (!isRedirectException(ex)) {
+ if (!isNot307And404Exception(ex)) {
Review Comment:
Good pointer! Now the implementation is only not `307 | 404`(so far, seems
broker will not throw other `30x`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
